Fixed Build 73 TCMD ConPTY tab eat lines after resizing window

[Alpengreis]

Build 73 (BTW: installer and updated check says 74) TCMD ConPTY tab eat lines after resizing the TCMD Window.

First it looks good:

then after resizing no more ...

It's truncated above!

PS: Does not happen in NON-ConPTY TCMD tab.

 

[rconn]

Try it with build 74 (already uploaded) and let me know if it behaves any differently.

If it still fails, try it with folding disabled.

Also try switching away from the TCMD window and back again to see if it's a rendering issue or a buffer issue.

 

[Alpengreis]

Still same problem with build 74.

No difference after I switched and back.

I have no folding option here, it's missed in german config, see here:

 

[rconn]

Try it with build 75 (already uploaded).

 

[Alpengreis]

Still the same ...

 

[rconn]

Cannot reproduce it here.

 

[Alpengreis]

Ok, that's bad. I can't change anything ...

 

[Alpengreis]

Also it's the first program which acts like that. Had it NEVER EVER before.

And last but not least, it had definitely to do with ConPTY ...

PS: Have tested it now also with SIFolding=No, no difference

 

[rconn]

Not happening here with 36.51.75, either increasing or decreasing the number of rows.

Strange things can happen when you decrease the number of columns, because TCMD has to start wrapping lines, but I can't make it fail by dragging the window taller or narrower.

Try turning off your fancy prompt and see if that makes a difference.

 

[Alpengreis]

I changed the prompt to $p$g, same result. I didn't decreased the colums in any way.

I just took the bottom right corner and shrink the window "hard" then back.

The text moves upwards and never returns.

PS: It also happens after I make the windows smaller vertically only. So it has nothing to do with wrapping.

 

[rconn]

I was eventually able to reproduce this on a backup system. It turned out to be ConPTY deleting the lines, not TCMD (or TCC). It also explained some peculiar architecture I had puzzled over in Windows Terminal; they knew about ConPTY's undocumented behavior and had designed WT to not be affected by it.

I created a (different) workaround in build 76 (already uploaded). Long term I will probably make a (significant) architectural change to TCMD's ConPTY handling, but the workaround should solve this particular issue.

 

[Alpengreis]

Thank you, it's better, but not yet solved. Compare the dir listings below:

So, in the second listing, at least from bios.txt till jobs2.txt the entries are missing after resizing and back ... they were just cutted out!

 

[rconn]

Unclear to me what you're doing - you said "after resizing and back", but your two clips have a different window size (unless you're copying only a portion of the window, which makes it really hard to correlate the differences).

Please provide a detailed reproducible failcase, specifying everything you're doing in that window. How you're resizing, the number of lines you are adding / removing, whether you're changing the columns size as well, version of Conhost, the window size (rows x columns), the buffer size, whether the TCC version is the same as the TCMD version, and anything else that would make it easier for me to duplicate your environment.

 

[Alpengreis]

I just made 2 dir commands then made window much smaller with right corner and then bigger again. And lines I described were missed.

I will try to make a video about it soon. Currently it's bed time ...

 

[rconn]

"Much smaller" is somewhat cryptic - were you trying to make it smaller than 80x25? That will break ConPTY.

 

[Alpengreis]

A good example is this here:

1. I opened TCMD
2. I made the size of window as you can see in screenshot
3. I made DIR

As you can see, all is truncated below!

 

[vefatica]

I can reproduce that.

Start TCMD (pos=354,56,1213,921 is normal and remembered, 128x42 chars).

Resize it a bit. I dragged the lower right corner and got pos=354,56,1171,898.

Execute DIR that will cause scrolling.

Here's the bottom of the window.

 

[vefatica]

Note that that's nowhere near the end of DIR's output. As @Alpengreis said, a lot of lines (all but the first page) were lost.

 

[rconn]

A good example is this here:

1. I opened TCMD
2. I made the size of window as you can see in screenshot
3. I made DIR

As you can see, all is truncated below!

Did you increase or decrease the window size?

You're still providing me with a summary, when what I need is a detailed step-by-step log.

 

[rconn]

I can reproduce that.

Start TCMD (pos=354,56,1213,921 is normal and remembered, 128x42 chars).

Resize it a bit. I dragged the lower right corner and got pos=354,56,1171,898.

Execute DIR that will cause scrolling.

Here's the bottom of the window.

View attachment 6113

So you shrank the window? By how many lines & columns?

 

[Alpengreis]

I decreased the window to that size ...

 

[vefatica]

So you shrank the window? By how many lines & columns?

I don't think it matters but I'll try to figure it out (might be hard).

 

[vefatica]

That wasn't so bad. Same experiment as earlier. I decreased the window 2 columns and 1 row. I issued DIR (caused scrolling) and wound up here, with only DIR's first page showing; there's nothing hiding below.

 

[vefatica]

Only the vertical matters. I did it again only decreasing rows by 2; same result. If I decrease only the number of columns, it's OK.

 

[rconn]

Only the vertical matters. I did it again only decreasing rows by 2; same result. If I decrease only the number of columns, it's OK.

Not reproducible here.

I need a lot more information than I'm getting:

1. Is this immediately after opening the TCMD window, or did you do something first?
2. If you did something else first, did you scroll the display?
3. You've got a custom prompt - try resetting it to the default prompt.
4. Instead of providing a tiny screenshot of a couple of lines, please show the entire TCMD window.
5. I still don't have a clear understanding of what you're doing and what the result is. Are you saying that you do a DIR, it causes scrolling, and you end up on the first page and it didn't scroll? So -- it scrolled, or it didn't scroll? Or it didn't scroll, but it should have scrolled?

The bug here is in ConPTY, not in TCMD, so I can't just look at TCMD source code. I need to know EXACTLY WHAT YOU"RE DOING AND WHAT HAPPENS, EVERY STEP OF THE WAY, so I can try to come up with a workaround for ConPTY's bad behavior.

 

[Alpengreis]

For me:

1. Yes, immediately after, I shrinked the window and typed DIR
2. No, expcept I had tested with "clear" prompt, see 3., but the prompt is NOT the reason
3. Tested with $p$g too (made that first)
4. see my screenshots for the last example ... just after started a fresh TCMD, I made window smaller (vertically too), then made a dir, thats all
5. No it's truncated, has nothing to do with scrolling, the lines are missing, away, gone, no more there ...

I repeat:

1. opened a fresh TCMD
2. shrinked the window as you can see in my screenshot above
3. made dir command

THAT'S ALL
the lines are missing, away, gone, no more there ... has nothing to do with scrolling

 

[vefatica]

Immediately after starting except (this time) for UNSET PROMPT. I guess I should have said DIR would cause scrolling. The scroll bar moved a bit. There's nothing hiding below the viewport. Here's the whole window.

 

[rconn]

I tried this on three systems here, all running 36.51.76, and it works perfectly on all three. I definitely see nothing like what you're getting.

This is what I get:

1. Start TCMD
2. Resize the window by dragging the bottom edge up a couple of lines.
3. enter DIR
4. DIR outputs a couple of pages, and the caret is at the bottom of the viewport on the third buffer page.

Just to verify what's happening on your systems - if you do a DIR after starting TCMD, and you haven't resized it, DIR outputs and scrolls as expected? If that works, is the behavior any different if you resize after the DIR, and then do another DIR?

And you're both sure you're running TCMD build 76? (TCC version is irrelevant here.)

 

[rconn]

One more question: are you running conhost or openconsole?

 

[vefatica]

I'm runnind build 76 ... conhost (how would one use openconsole?). If I do nothing else, a second DIR after resizing is OK. If, after the first DIR, I CLS (or echos ^e[2J^e[3J^e[H), and then resize, a subsequent DIR screws up as described previously.