QueryIsFile() in 30.00.20

[Charles Dye]

It looks like QueryIsFile() does Bad Things in 30.00.20. I can't imagine why the function itself would have changed. RTL "improvement" ?

 

[rconn]

The QueryIsFile API changed to allow an optional second argument:

DLLExports int WINAPI QueryIsFile( LPCTSTR, CAtlString * strFound=NULL );

 

[vefatica]

The QueryIsFile API changed to allow an optional second argument:

DLLExports int WINAPI QueryIsFile( LPCTSTR, CAtlString * strFound=NULL );

So how should a plugin author proceed?

 

[rconn]

I didn't know the compiler would break old code on an optional new argument. For build 21 (which I'll post shortly) I named the new version QueryIsFileEx.

 

[vefatica]

I didn't know the compiler would break old code on an optional new argument. For build 21 (which I'll post shortly) I named the new version QueryIsFileEx.

Will we need a new header and library?

 

[vefatica]

FWIW, I found this on StackOverflow (6 years old)

BOOL FileExists(LPCTSTR szPath)
{
  DWORD dwAttrib = GetFileAttributes(szPath);

  return (dwAttrib != INVALID_FILE_ATTRIBUTES && 
         !(dwAttrib & FILE_ATTRIBUTE_DIRECTORY));
}

 

[Charles Dye]

FWIW, I found this on StackOverflow (6 years old)

BOOL FileExists(LPCTSTR szPath)
{
  DWORD dwAttrib = GetFileAttributes(szPath);

  return (dwAttrib != INVALID_FILE_ATTRIBUTES &&
         !(dwAttrib & FILE_ATTRIBUTE_DIRECTORY));
}

Mine is a bit more ornate. But since you like elegant... note that INVALID_FILE_ATTRIBUTES has FILE_ATTRIBUTE_DIRECTORY set.

 

[Charles Dye]

I didn't know the compiler would break old code on an optional new argument. For build 21 (which I'll post shortly) I named the new version QueryIsFileEx.

Thank you for that. I could dig out all calls to QueryIsFile() in all of my old plugins, but would prefer not to!